Skip to content

fix: long version info not displayed correctly in release builds#1374

Merged
jooola merged 4 commits intomainfrom
fix-long-version-info
Mar 30, 2026
Merged

fix: long version info not displayed correctly in release builds#1374
jooola merged 4 commits intomainfrom
fix-long-version-info

Conversation

@phm07
Copy link
Copy Markdown
Contributor

@phm07 phm07 commented Mar 26, 2026

Goreleaser allows injecting the vcs.revision and vcs.time variables directly using ldflags, which is more reliable than using debug.ReadBuildInfo() and should fix the long version output for GitHub releases. debug.ReadBuildInfo() is still used as a fallback in case the binary was not built using goreleaser. The go mod tidy before hook was removed from the goreleaser config as we already keep our go mod tidied using renovate.

@phm07 phm07 self-assigned this Mar 26, 2026
@phm07 phm07 requested a review from a team as a code owner March 26, 2026 14:47
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (9c284a1) to head (baad337).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/version/version.go 47.36% 5 Missing and 5 partials ⚠️
internal/cmd/version/version.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   67.59%   72.61%   +5.01%     
==========================================
  Files         300      300              
  Lines       11054    11067      +13     
==========================================
+ Hits         7472     8036     +564     
+ Misses       2641     2133     -508     
+ Partials      941      898      -43     
Flag Coverage Δ
e2e 51.32% <37.50%> (?)
unit 67.56% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 requested a review from jooola March 27, 2026 16:36
@jooola jooola merged commit 25fbaf2 into main Mar 30, 2026
7 checks passed
@jooola jooola deleted the fix-long-version-info branch March 30, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants